remove shebang-regex #4
Conversation
|
Seems like the travis errors on node 0.10 and node 0.12 comes from babel |
|
Making libraries to re-use code isn't a bad thing, but they have an overhead (package.json, license file, import syntax...) and in the case of shebang-regex that overhead is bigger than the code itself. Moreover the shebang syntax has not changed since 1980 and has zero reason to change so copy-pasting the regex is as usefull as pulling in a package. |
|
Totally agree with @bibo5088. Any decent programmer who knows how to use regular expressions should be able to write a regex that tests whether a string starts with |
|
|
Hello,
The actual shebang regex is 9 characters long, the import syntaxe is longer than the actual regex and the package also contains a license, a package.json file, a readme and a type definition file !
The package is 2 828 bytes while the regex is only 9 bytes, it is 314 times bigger than the regex.
shebang-command has 9 223 330 weekly downloads, if we remove the package we can save 26 000 567 270 bytes (More than 2,6 Gb) bytes of useless files.
Also more packages means more risk, here's an article talking about it :
I’m harvesting credit card numbers and passwords from your site. Here’s how.
An incident has already happened this year with the package event-stream :
Malicious code found in npm package event-stream downloaded 8 million times in the past 2.5 months